-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Drag'n'drop: avoid unintended drag on hover (WTrackProperty, WCoverArt etc.) #13035
Conversation
@m0dB Do you have any idea what's going on? |
Meeh, breaks dnd in the tracks table... wtf |
I think it is an issue that in mouseMoveInitiatesDragHelper()
are static and are never reset. |
I am able to reproduce it without a hover effect. |
Okay, thanks. However it's different with WTracktableView: |
Before #12903, the check for the pressed button was in the mouseMoveEvent() of each widget. Maybe we want to reintroduce it. |
Appearantly. I managed to suppress unintented drag by initializing them both with -1. Turns out I don't fully understand the combination of static function + namespace inline function with static var. |
These static vars are like globals, hidden in a function scope. |
Uff, there's a difference between edit at least for mouse moves. |
Works as expected with all track widgets and the table. |
Turns out that doesn't matter with the correct button filter. |
@mixxxdj/developers Could someone take a look please? Drag'n'drop should work as expected and no unintended drag must occur. |
I'll take a look when I have a moment, hopefully tonight (CET). |
LGTM, merged. Thanks for taking care of this while I was away. |
Fixes #13033 on Linux with Qt 6.2.3