Tango :: box for Pitch slider, improve skin menu, fix glitches

[ronso0]

This fixes some glitches and makes the skin more consistent.
This can be merged, unless someone finds other bugs since last update.

Update 2017-11-24

Considering this was not reviewed yet except by @daschuer I decided to merge my other Tango branch.

Update 2017-11-28

I decided to make some design steps backwards and move all skin toggles as well as Master & Headphone mixer to topbar, grant Mic & Aux their own section below Samplers, and thereby make 'netbook mode' obsolete.
Center section with channel mixer and level meters is much clearer, and in general Tango is way more compact now.

Major changes:

• adopt 'netbook/compact mode' as only view mode
• boxes for pitch rate/key column
• separate buttons for temporary rate/key changes
  (missed them without controller, optional, default: off)
• replace HotCue toggle with Loop/Beatjump toggle
  (with controller available I toggle this much more often than HotCues)
• finally satisfying UX in skin settings menu

Also I fixed some glitches only visible with screens wider than ~1600px.

To test:

• are the rate/key buttons discoverable? do the icons suit well?
• in skin settings, check configurations of HotCues, Spinny/Cover, EffectUnits and Sampler rows
• is Vinyl status light working properly?
• do you experience a horizontal flickering when expanding Effect Units?
• is the clock format matching your locale? (AM/PM, seconds, 12/24 hours)

Ideas:

• would a gear icon suit the skin settings toggle better than current 'hamburger' button?

[ronso0]

Changes in this PR:

• prevent flickering FX units when expanding
• align Master level meter, top bar and Crossfader for all configurations
• make button effects consistent, enlarge Deck Controls toggle
• relax clock area

@nikmartin @nopeppermint @InannaMoon @naughty101
Anyone likes to test this?
Also, does anyone of you use a blinking Cue mode like Pioneer or Denon mode? If so, how does it feel?

[daschuer]

I am not sure if I am qualified, but It looks good to me.

I have found some unrelated issues.

• If you hoover the broadcast icon it becomes normal.
• The hamburger menu is hard to discover, I was searching on the left and right top.
  ** I think we should add a "Show skin options" or something, into the standard view menu. To have a unified backup for all skins.

What do you think?

Should I merge this, or should someone else have a look?

[ronso0]

I think we should add a "Show skin options" or something, into the standard view menu. To have a unified backup for all skins

Definitely a good idea!

The hamburger menu is hard to discover, I was searching on the left and right top

Do you think this is because the icon blends in too much?
Becasue in normal mode (not netbook) I don't see a better place in the current layout.

If you hoover the broadcast icon it becomes normal

This should indicate that status will be switched to "Off" as was before activation. If you think this is not working out, I can either change the icon to something more alerting or just don't alter the icon when it's hovered. I don't mind either way

[ronso0]

Here I was just shifting pixels and swapping stuff behind the scenes, and used it for a few days, I think it's ready to merge.

I have another branch ready, and plan to push the commits when I'm back home next days, so if anything slipped through my fingers I can can fix it then.

[ronso0]

Just tested on a friend's machine and found an issue in the FX units that only appears on huge screens.
Will fix it soon but also include the other changes here I think

[Be-ing]

** I think we should add a "Show skin options" or something, into the standard view menu. To have a unified backup for all skins.

I think we should work towards removing the top menu. It is mostly a waste of space, especially in full screen mode.

[Be-ing]

There is a merge conflict since #1300 was merged.

I'll test this soon.

[ronso0]

That was a stupid merge conflict...resolved now

[nikmartin]

The two blank spaces below the spinnies, do these ever hold anything? Seems like wasted space that an elapsed/remaining time or something else could go in:

[ronso0]

• brighter inactive FX toggle
• alternate FX selctor drop-down icon
  and small fixes

[ronso0]

The two blank spaces below the spinnies, do these ever hold anything? Seems like wasted space that an elapsed/remaining time or something else could go in

Only when mixer is not displayed this space is filled to avoid gaps in skin grid.
Good idea to put time there, but only Elapsed OR Remaining could fit (maybe), elapsed AND remaining wouldn't. So this is not an option.
Also time would have to go back to decks' artist/title row when mixer is displayed and smalll spinny/cover is enabled (like on netbooks).

I think Tango is already juggling available space, if I'd push this even further I'd probaly go mad, and
we don't want that...

[daschuer]

I have played a bit with it and it is really grate now. It is amazing how configurable it is now.
I can merge it now if you like.

Here some comments:

One thing I miss hardly after starting Tango with default settings is the Cue button. Can we enable it by default? The label C is unfortunately not self explaining. How about drawing a narrowed or overlapping CUE Icon?

Wen the menu is enabled, the top row is overlapping. Can't we just remove the gear icon in this case?
It is nice to have the menu in the same place for Deere and tango, can we also unify the icon? This will be one of the first item the user is looking for after switching the skin.

[ronso0]

I have played a bit with it and it is really grate now. It is amazing how configurable it is now.

Cool, thanks! I got so used to it over the last weeks, I wouldn't go back to old design..

One thing I miss hardly after starting Tango with default settings is the Cue button. Can we enable it by default? The label C is unfortunately not self explaining. How about drawing a narrowed or overlapping CUE Icon?

Yes, it makes sense to have it visible by default. Fixed.
Apparently there's now common Cue icon. I can label it Q (my favourite) like on Reloop controllers (they also use a cup icon for CueAndPlay :), or just CUE and decrease font size:

Wen the menu is enabled, the top row is overlapping. Can't we just remove the gear icon in this case?

Yes, good idea, I'll remove the icon. The floating menu was much better, but it fails on some OSX', so unfortunately there are a few glitches with the menu @1024PX.
I'll try to fix them and ping you for merging. Won't take long.

It is nice to have the menu in the same place for Deere and tango, can we also unify the icon? This will be one of the first item the user is looking for after switching the skin.

Actually I like the gear icon much more now, it's more distinct. But we can change it in Deere..

[daschuer]

CUE and Q are working for me.

Mixxx has a CUP control "cue_play" as well, and a "play_stutter".
Play stutter would work for me as a single button in Denon mode if right click is pause.
But that is probably to advanced.

[ronso0]

• Cue is labeled Q now
• everything is fine on small screens now, too (except little squeezed topbar with skin menu open, but this is a tiny issue )
• skin menu toggle is hidden when menu is active

@daschuer
I'm done here, please merge.

[daschuer]

Impressing! Thank you for the hard work, revising everything over an over again.

[foss-]

Seeing Tango evolve so nice brings a smile to my face. Thanks @ronso0 <3
Has there been a decision about default skin for next stable release? If not, I'd propose Tango. It looks contemporary / up-to-date and works very well.

[ronso0]

Seeing Tango evolve so nice brings a smile to my face. Thanks @ronso0 <3

You're welcome! Recently I tried my first version from the forums again, had to smile as well...

[nikmartin]

I tried my first version from the forums again, had to smile as well...

Yes, I started using Tang as soon as I saw it on the forum, and am impressed how far it's come. I frequently recommend it as the default starting skin for people on reddit/r/DJs and will be doing a short mixxx howto setup and configure tutorial video on mixxx and will use Tango

[foss-]

minor UI issue: when using symmetric layout for Time / Duration the alignment of running time and total time is off for the right deck.

mixxx master build 499 on macOS 10.13.2.

Let me know if you can confirm this and if so, if you prefer to have this filed as launchpad bug. I thought I'd comment here since it felt appropriate.

Should the cue marker in the waveform be named "Q" as well for consistency or is that a bad idea?

[ronso0]

minor UI issue: when using symmetric layout for Time / Duration the alignment of running time and total time is off for the right deck.

Whoopsy!

Should the cue marker in the waveform be named "Q" as well for consistency or is that a bad idea?

Nice catch. For consistency it should be Q.

I guess minor issues will pop up anyway, so let's collect them here. I'll check launchpad as well.

[Be-ing]

Yes, I started using Tang as soon as I saw it on the forum, and am impressed how far it's come. I frequently recommend it as the default starting skin for people on reddit/r/DJs and will be doing a short mixxx howto setup and configure tutorial video on mixxx and will use Tango

Cool! I am planning on making a tutorial video for the new effects system sometime between 2.1 beta and the 2.1 final release. Were you planning on making that video soon? It would be awesome if we could include it in the 2.1 beta release announcement. Maybe you could make a walkthrough of the Mixtrack Pro 3 mapping.

And yes, excellent job with Tango, @ronso0!! 🙌

[ronso0]

Yeah, thanks to all for your feedback and your ideas!
Looking forward to those tutuorials!

Remaining issues are fixed here:
ronso0:tango-tiny-fixes
right decks: align play position display with duration
use Q as main cue point label on waves
center Waveforms' PlayPosition marker
simplify master vu
make loop/jump switch simpler
use [Master],show_eqs & [Master],show_superknobs, fix CO typo in menu
etc.