Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tango skin :: hidpi fixes #1527

Merged
merged 16 commits into from
Mar 1, 2018
Merged

Tango skin :: hidpi fixes #1527

merged 16 commits into from
Mar 1, 2018

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 26, 2018

I fixed some major bugs appearing when Tango skin is scaled up (see lp:1751290), as well as some minor UX issues

  • qss: split 'background' shorthand into 'background-color' and 'image' (otherwise those images stayed at 100%)
  • Fx flow graphics (were completely gone, width of 'border-image' was not scaled)
  • Effect selector (removed explicit 'size', added background to effect list toggle, fix scaling of WEffectSelector and WBeatSpinBox #1518 also fixes the effects list display)
  • Fx parameter row (rebuild, margin is not scaled but was necessary for previous stacked layout)
  • beatsize spinboxes, buttons & spinbox in Library
  • borders in sampler and preview deck

Screenshot 1920x1080, mixxx & system font at 200%
tango-hidpi-x2_2018-02-27

@ronso0
Copy link
Member Author

ronso0 commented Feb 27, 2018

Don't merge yet, I need to fix Artist/Time row and Overview.

@ronso0
Copy link
Member Author

ronso0 commented Feb 27, 2018

Ready to test!

@ronso0
Copy link
Member Author

ronso0 commented Mar 1, 2018

I just finished this PR.
Besides the scaling fixes, there are a few minor changes:

  • FX unit labels and show_parameters toggle have a background now, so they visually relate more to the actual FX unit. Same applies to sampler row expand toggle
  • toggle for additional, hidden deck controls (quantize, repeat etc.) now sits at the outside of deck buttons row
  • right-hadn decks' Artist/Title are aligned right (fixes A. of lp:1750902)
  • I removed Library toggle from the top row. Didn't use it much, Alt+Tab is much quicker to hide tracks and playlists from snoopy fellows

@Be-ing Be-ing merged commit 1ce75a6 into mixxxdj:2.1 Mar 1, 2018
@Be-ing
Copy link
Contributor

Be-ing commented Mar 1, 2018

LGTM, thanks!

@@ -51,10 +51,10 @@ Variables:
</Template>

<EffectSelector>
<Size>82f,20f</Size>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke the scaling with #1518. I'll revert it in that PR.

@ronso0 ronso0 deleted the tango-hidpi-fixes branch March 2, 2018 17:43
@ronso0
Copy link
Member Author

ronso0 commented Mar 3, 2018

it seems this was merged too early: I just discovered a bug with some button icons after I fixed those to scale well. All pause icons appear blurred, although at least their height matches the buttons' height.

Fixed in #1531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants