-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for platform-dependent skin styles + fix WEffectSelector styling #1590
Conversation
6766f3b
to
712a1c2
Compare
How does it work? Please add a short description to the source code and the wiki. |
This allows the |
This may turn out to be useful for other problems in the future as well as the present issue with WEffectSelector. |
Could you test it for WEffectSelector? |
712a1c2
to
d8cd18b
Compare
This will allow us to work around platform-dependent quirks in styling. For 2.1 this is needed to work around the issue of the checkmark pushing text to the right and getting cut off in WEffectSelector only on macOS.
d8cd18b
to
dd1b0df
Compare
Hopefully for real this time
3024af0
to
050a05e
Compare
I double checked with #1592 merged in and the drop down menus still look good. |
I'll merge this now to ensure the skins are in their final state for the screenshots in #1525 and so we can get builds to test on macOS with Retina screens and Windows. |
So I can remove the hack from Tango and bring back the tick mark? |
This went to RC1, right? |
I think so, now that we have a way to hide it only on macOS.
Yes.
🤦♂️ You are right. Would you like to take care of that? |
@Be-ing This is how it looks right now on windows or is this your WIP fix? So I move the current qss snippets to style-win.qss as it looks good on Windows, and put the Mac fixes into style-linux.qss, as well. Alright? |
I can't reproduce this at 100% scaling on my 3840 x 2160 screen, neither in GNOME nor KDE... 😵 |
Those screenshots were taken on Windows 7 with RC build 6663. |
Do you mean keep the Mac fixes in style-mac.qss and make new style-linux.qss files? |
Mine were taken with the same build. ubuntu studio 14.04 with xfce4. |
Note that if you add other platform-specific style sheets you need to list them in the <Style> element in skin.xml as described above. |
fixed in #1596 |
This will allow us to work around platform-dependent quirks in styling. For 2.1 this is needed to work around the issue of the checkmark pushing text to the right and getting cut off in WEffectSelector only on macOS.