Support dragging track from deck to deck #173
Conversation
Conflicts: src/skin/legacyskinparser.cpp
|
Thanks for picking this up. Drag from Deck to Deck = OK One possible addition would be to display the |
| @@ -782,19 +782,22 @@ QWidget* LegacySkinParser::parseVisual(QDomElement node) { | |||
|
|
|||
| QWidget* LegacySkinParser::parseText(QDomElement node) { | |||
| QString channelStr = lookupNodeGroup(node); | |||
| const char* pSafeChannelStr = safeChannelString(channelStr); | |||
There was a problem hiding this comment.
This is off topic and the rest of the code is also effected (not your fault):
IMHO it should be "save" = de:gespeichert not "safe" (security) = de:gesichert
The string is saved into heap, because channelStr will be deleted from stack after returning from parseText().
Maybe a native speaker can verify it.
Because of this, pSafeChannelStr should become pSavedChannelStr.
There was a problem hiding this comment.
Safe in this case means "safe to use without crashing" not "save it for later" so I think the current wording is fine.
There was a problem hiding this comment.
Ok, then safe us from the work ;-)
|
Hi @loadstar81 |
| @@ -806,20 +809,22 @@ QWidget* LegacySkinParser::parseText(QDomElement node) { | |||
|
|
|||
| QWidget* LegacySkinParser::parseTrackProperty(QDomElement node) { | |||
| QString channelStr = lookupNodeGroup(node); | |||
|
|
|||
| const char* pSafeChannelStr = safeChannelString(channelStr); | |||
There was a problem hiding this comment.
Oh, it looks like we usually use const char* for group names. nevermind.
|
Thanks for the review guys! I'll make some changes and rescope. |
|
Updated the tooltip and changed drag creation to the mouseMove event. I plan to subclass the common dNd parts, but I'll leave that for another pull request! |
|
Looks good to me! Thanks @loadstar81 :) |
|
Could you sign the contributor agreement? I think your last commits were from before we started doing this: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?usp=drive_web&formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ#gid=0 This just keeps a record of our permission to distribute your changes with Mixxx. |
Support dragging track from deck to deck
|
signed! \m/ |
Pelican fixes (round 2)
This is my branch corresponding to https://bugs.launchpad.net/mixxx/+bug/1173481
Please look it over if you have time and leave me some feedback. I had some trouble figuring out how to unit test the new functionality, but would gladly implement tests if I was pointed in the right direction.
Thanks!