Support dragging track from deck to deck #173
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,15 @@ | ||
|
|
||
| #include <QDebug> | ||
| #include <QUrl> | ||
|
|
||
| #include "controlobject.h" | ||
| #include "widget/wtrackproperty.h" | ||
|
|
||
| WTrackProperty::WTrackProperty(const char* group, ConfigObject<ConfigValue>* pConfig, QWidget* pParent) | ||
| : WLabel(pParent), | ||
| m_pGroup(group), | ||
| m_pConfig(pConfig) { | ||
| setAcceptDrops(true); | ||
| } | ||
|
|
||
| WTrackProperty::~WTrackProperty() { | ||
|
|
@@ -41,3 +48,47 @@ void WTrackProperty::updateLabel(TrackInfoObject*) { | |
| } | ||
| } | ||
| } | ||
|
|
||
| void WTrackProperty::mouseMoveEvent(QMouseEvent *event) { | ||
| if ((event->buttons() & Qt::LeftButton) && m_pCurrentTrack) { | ||
| QList<QUrl> locationUrls; | ||
| locationUrls.append(QUrl::fromLocalFile(m_pCurrentTrack->getLocation())); | ||
|
|
||
| QMimeData* mimeData = new QMimeData(); | ||
| mimeData->setUrls(locationUrls); | ||
|
|
||
| QDrag* drag = new QDrag(this); | ||
| drag->setMimeData(mimeData); | ||
| drag->setPixmap(QPixmap(":images/library/ic_library_drag_and_drop.png")); | ||
| drag->exec(Qt::CopyAction); | ||
| } | ||
| } | ||
|
|
||
| void WTrackProperty::dragEnterEvent(QDragEnterEvent *event) { | ||
| if (event->mimeData()->hasUrls() && | ||
| event->mimeData()->urls().size() > 0) { | ||
| // Accept if the Deck isn't playing or the settings allow to interrupt a playing deck | ||
| if ((!ControlObject::get(ConfigKey(m_pGroup, "play")) || | ||
| m_pConfig->getValueString(ConfigKey("[Controls]", "AllowTrackLoadToPlayingDeck")).toInt())) { | ||
| event->acceptProposedAction(); | ||
| } else { | ||
| event->ignore(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| void WTrackProperty::dropEvent(QDropEvent *event) { | ||
| if (event->mimeData()->hasUrls() && | ||
| event->mimeData()->urls().size() > 0) { | ||
| QUrl url = event->mimeData()->urls().first(); | ||
| QString filename = url.toLocalFile(); | ||
| // If the file is on a network share, try just converting the URL to a string | ||
|
There was a problem hiding this comment. This comment did not at additional information. You might want to explain why this will work. There was a problem hiding this comment. This is actually a question I had myself. I saw this was how it was done in mixxx/src/widget/wwaveformviewer.cpp Line 169 in 7905a7e There was a problem hiding this comment. In #169 I've created a helper class for this so I'll just update it to use that once it merges. |
||
| if (filename == "") { | ||
| filename = url.toString(); | ||
| } | ||
| event->accept(); | ||
| emit(trackDropped(filename, m_pGroup)); | ||
| } else { | ||
| event->ignore(); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is off topic and the rest of the code is also effected (not your fault):
IMHO it should be "save" = de:gespeichert not "safe" (security) = de:gesichert
The string is saved into heap, because channelStr will be deleted from stack after returning from parseText().
Maybe a native speaker can verify it.
Because of this, pSafeChannelStr should become pSavedChannelStr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safe in this case means "safe to use without crashing" not "save it for later" so I think the current wording is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then safe us from the work ;-)