Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qm shift key detection chroma #2137

Merged
merged 2 commits into from
Sep 1, 2019
Merged

Qm shift key detection chroma #2137

merged 2 commits into from
Sep 1, 2019

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jun 2, 2019

Currently the chroma starts at full key C3, the 1/3 key below is not used.
This may leads to a lower value for C3.
This is fixed here.

@daschuer
Copy link
Member Author

daschuer commented Jun 5, 2019

It turns out that this has a rounding issue somewhere. A 440 Hz test is no in the center of one bin.
I keep investigating.

@daschuer daschuer changed the title Qm shift key detection chroma [WIP] Qm shift key detection chroma Jun 5, 2019
@daschuer daschuer changed the title [WIP] Qm shift key detection chroma Qm shift key detection chroma Jun 7, 2019
@daschuer
Copy link
Member Author

daschuer commented Jun 7, 2019

OK, issues are fixed.

@uklotzde
Copy link
Contributor

uklotzde commented Aug 8, 2019

Any plans for an upstream patch?

@daschuer
Copy link
Member Author

Any plans for an upstream patch?

c4dm/qm-dsp#3

@daschuer
Copy link
Member Author

ready.

@uklotzde
Copy link
Contributor

uklotzde commented Sep 1, 2019

LGTM. Hopefully we can drop our patches eventually with an upcoming qm-dsp update.

@uklotzde uklotzde merged commit 838b3d6 into mixxxdj:master Sep 1, 2019
@daschuer daschuer deleted the qm-shift branch September 26, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants