Stanton DJC.4 mapping #2607
Merged
Stanton DJC.4 mapping #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
requested changes
Mar 29, 2020
|
Thanks for using components JS. This makes reviewing much more straight forward. Mapping looks pretty good so far. |
To adjust the size there are the half/double buttons and this behavior is closer to the mapping of other controllers like the VCI-400
Holzhaus
requested changes
Apr 2, 2020
There was a problem hiding this comment.
Thank you very much for your contribution. The code looks very good - it's cool that you used our components library. The documentation on the wiki is great and I'm sure other users that have this controller will benefit from that.
I found some extremely minor code style issues. I'll merge when they're resolved.
- Changed class name to uppercase (DJC4 instead of djc4) - Improved controller description
|
Can you add a commit that adds an entry to |
|
Please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapping for the Stanton DJC.4 controller.
Documentation: https://mixxx.org/wiki/doku.php/stanton_djc.4
I tried to follow the contribute mapping guide and the suggestions made in Denon MC7000 pull request discussion.
The files pass the pre-commit hooks on my machine (clang disabled, because it's not installed).