Micro optimize ControlObject::set() double vs double& #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These functions get called a lot, so even micro optimization is worth it. LGTM |
|
Thank you for review |
daschuer
added a commit
that referenced
this pull request
Jun 30, 2013
Micro optimize ControlObject::set() double vs double&
Merged
11 tasks
daschuer
pushed a commit
that referenced
this pull request
Oct 22, 2019
Hotcue conflicts in LateNight, fix for Shade mini decks
Holzhaus
pushed a commit
to Holzhaus/mixxx
that referenced
this pull request
Aug 23, 2020
clarify use of PFL button
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
- mixxx-devel as announcement channel until Zulip has default notification streams. - Re-order options in order of read preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is faster on 64 bit machines anyway. On 32 bit targets this version benefits from compatible method parameters. Not proved, because asm code is not comparable due to inter-function optimization. Bud it should not be worse.
see: https://github.com/mixxxdj/mixxx/pull/28/files#r4952818