Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmake macos warnings #2901

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Cmake macos warnings #2901

merged 3 commits into from
Jun 29, 2020

Conversation

daschuer
Copy link
Member

Fix some warnings in cmake builds on macOs

@Holzhaus
Copy link
Member

Thanks, can this go into 2.3?

@Holzhaus Holzhaus changed the base branch from master to 2.3 June 24, 2020 09:36
@Holzhaus Holzhaus changed the base branch from 2.3 to master June 24, 2020 09:37
Holzhaus
Holzhaus approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Can you rebase on 2.3?

@daschuer daschuer mentioned this pull request Jun 29, 2020
Merged
@daschuer daschuer changed the base branch from master to 2.3 June 29, 2020 07:16
@daschuer
Copy link
Member Author

Rebase done.

@uklotzde
Copy link
Contributor

Already approved and CI builds passed after rebasing. LGTM. Thank you!

@uklotzde uklotzde merged commit 63fce7e into mixxxdj:2.3 Jun 29, 2020
@daschuer daschuer deleted the cmake_macos_warnings branch September 26, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @Holzhaus @uklotzde