Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlaylistDAO: Add missing spaces in SQL query #2906

Merged
merged 2 commits into from
Jun 30, 2020
Merged

PlaylistDAO: Add missing spaces in SQL query #2906

merged 2 commits into from
Jun 30, 2020

Conversation

uklotzde
Copy link
Contributor

Fixup of #2900, didn't notice in the logs:

Warning [Main]: /tmp/mixxx/src/library/dao/playlistdao.cpp 413 FAILED QUERY [ "SELECT p1.position FROM PlaylistTracks AS p1WHERE p1.id NOT IN (SELECT p2.id FROM PlaylistTracks AS p2INNER JOIN library ON library.id = p2.track_id WHERE p2.playlist_id = p1.playlist_id AND library.mixxx_deleted = 0 ) AND p1.playlist_id=:id" ] QSqlError("", "Parameter count mismatch", "")

That's the reason why I prefer to use VERIFY_OR_DEBUG_ASSERT around query preparation and execution to detect such errors early.

@uklotzde uklotzde added this to the 2.4.0 milestone Jun 29, 2020
@uklotzde uklotzde requested a review from Holzhaus June 29, 2020 22:09
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI.

@Holzhaus Holzhaus merged commit e014ecd into mixxxdj:master Jun 30, 2020
@uklotzde uklotzde deleted the playlistdao branch July 8, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants