Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlaylistDAO: Add missing spaces in SQL query #2906

Merged
merged 2 commits into from
Jun 30, 2020
Merged

PlaylistDAO: Add missing spaces in SQL query #2906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e1dada
Add missing space characters in SQL query
uklotzde Jun 29, 2020
cf4073e
Delete redundant space characters from SQL query
uklotzde Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/library/dao/playlistdao.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,12 +399,12 @@ void PlaylistDAO::removeHiddenTracks(const int playlistId) {
// phantom track_ids with no match in the library table
QSqlQuery query(m_database);
query.prepare(QStringLiteral(
"SELECT p1.position FROM PlaylistTracks AS p1"
"SELECT p1.position FROM PlaylistTracks AS p1 "
"WHERE p1.id NOT IN ("
"SELECT p2.id FROM PlaylistTracks AS p2"
"INNER JOIN library ON library.id = p2.track_id "
"WHERE p2.playlist_id = p1.playlist_id "
"AND library.mixxx_deleted = 0 ) "
"SELECT p2.id FROM PlaylistTracks AS p2 "
"INNER JOIN library ON library.id=p2.track_id "
"WHERE p2.playlist_id=p1.playlist_id "
"AND library.mixxx_deleted=0) "
"AND p1.playlist_id=:id"));
query.bindValue(":id", playlistId);
query.setForwardOnly(true);
Expand Down