Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database help message #2979

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Update database help message #2979

merged 3 commits into from
Aug 6, 2020

Conversation

xeruf
Copy link
Contributor

@xeruf xeruf commented Jul 31, 2020

Users are still pointed to some ancient mailing list no-one uses anymore.
I changed "contact" to "consult" rather than "see" because it is reasonably general and thus allows us to point to almost anything without having to change the wording again.

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This generally LGTM, but I'm unsure if it makes sense to update the TS files as these are pull edfrom Transifex anyway IIRC.

@Holzhaus Holzhaus requested a review from daschuer August 1, 2020 09:09
@xeruf
Copy link
Contributor Author

xeruf commented Aug 1, 2020

Ah ok, I wasn't involved in the translation yet.

@uklotzde
Copy link
Contributor

uklotzde commented Aug 3, 2020

Those files are generated by Transifex. Modifying them locally is pointless.

@Holzhaus
Copy link
Member

Holzhaus commented Aug 3, 2020

@xerus2000 Can you run git reset HEAD~1 -- res/translations to remove the translation changes then?

@xeruf
Copy link
Contributor Author

xeruf commented Aug 3, 2020

But how are the strings updated then? I don't see a need to retranslate it in all languages.

@uklotzde
Copy link
Contributor

uklotzde commented Aug 4, 2020

What's the reason for 2f5be78 Reorder schema update function signature?

@xeruf
Copy link
Contributor Author

xeruf commented Aug 4, 2020

It is much more likely that you want to specify a different target schema version rather than a different schema file. Since you don't seem to like to have separate PRs for such things, I thought it would fit in here.

@uklotzde
Copy link
Contributor

uklotzde commented Aug 4, 2020

It is much more likely that you want to specify a different target schema version rather than a different schema file. Since you don't seem to like to have separate PRs for such things, I thought it would fit in here.

This is just an assumption and guessing. Don't change existing code without any actual requirements.

src/database/mixxxdb.h Show resolved Hide resolved
@@ -1,10 +1,7 @@
#ifndef TRACKID_H
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid to include unrelated changes in future PRs.

@uklotzde
Copy link
Contributor

uklotzde commented Aug 6, 2020

LGTM

@uklotzde uklotzde merged commit 56e7294 into mixxxdj:master Aug 6, 2020
@xeruf xeruf deleted the database-help branch August 25, 2020 12:41
daschuer added a commit to daschuer/mixxx that referenced this pull request Aug 18, 2021
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants