DlgPrefRecord: enable CUE sheet recording by default #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
force-pushed
the
cue_sheet_default
branch
from
ffac0aa
to
58d2cd9
Compare
daschuer
requested changes
Nov 26, 2020
A CUE sheet cannot be created retroactively after making a recording, so it is better to have it on by default. If a user does not want them, they can delete the CUE files and turn off the option easily. As discussed on Zulip https://mixxx.zulipchat.com/#narrow/stream/109122-general/topic/Exporting.20a.20Mixcloud-digestable.20playlist
Be-ing
force-pushed
the
cue_sheet_default
branch
from
58d2cd9
to
c9e6e19
Compare
|
Okay, done. I will not do anymore refactoring of this legacy code. I am only changing this one boolean value; that's it. This preferences code needs an overhaul so that it is not possible to have the default value inconsistent in different places. |
uklotzde
approved these changes
Nov 26, 2020
|
Unrelated: I see varying and spurious(?) test failures on different Windows CI builds. This is strange. |
daschuer
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CUE sheet cannot be created retroactively after making a
recording, so it is better to have it on by default. If a user
does not want them, they can delete the CUE files and turn off
the option easily.
As discussed on Zulip
https://mixxx.zulipchat.com/#narrow/stream/109122-general/topic/Exporting.20a.20Mixcloud-digestable.20playlist