Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DlgPrefRecord: enable CUE sheet recording by default #3374

Merged
merged 2 commits into from Nov 27, 2020
Merged

DlgPrefRecord: enable CUE sheet recording by default #3374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9e6e19
DlgPrefRecord: enable CUE sheet recording by default
Be-ing Nov 26, 2020
a92532e
Define constant as constexpr
uklotzde Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/preferences/dialog/dlgprefrecord.cpp
View file
Open in desktop
Expand Up @@ -9,6 +9,9 @@
#include "control/controlproxy.h"
#include "util/sandbox.h"

namespace {
constexpr bool kDefaultCueEnabled = true;
} // anonymous namespace

DlgPrefRecord::DlgPrefRecord(QWidget* parent, UserSettingsPointer pConfig)
: DlgPreferencePage(parent),
Expand Down Expand Up @@ -69,8 +72,8 @@ DlgPrefRecord::DlgPrefRecord(QWidget* parent, UserSettingsPointer pConfig)
loadMetaData();

// Setting miscellaneous
CheckBoxRecordCueFile->setChecked(
(bool) m_pConfig->getValueString(ConfigKey(RECORDING_PREF_KEY, "CueEnabled")).toInt());
CheckBoxRecordCueFile->setChecked(m_pConfig->getValue<bool>(
ConfigKey(RECORDING_PREF_KEY, "CueEnabled"), kDefaultCueEnabled));

// Setting split
comboBoxSplitting->addItem(SPLIT_650MB);
Expand Down Expand Up @@ -173,8 +176,8 @@ void DlgPrefRecord::slotUpdate()
loadMetaData();

// Setting miscellaneous
CheckBoxRecordCueFile->setChecked(
(bool) m_pConfig->getValueString(ConfigKey(RECORDING_PREF_KEY, "CueEnabled")).toInt());
CheckBoxRecordCueFile->setChecked(m_pConfig->getValue<bool>(
ConfigKey(RECORDING_PREF_KEY, "CueEnabled"), kDefaultCueEnabled));

QString fileSizeStr = m_pConfig->getValueString(ConfigKey(RECORDING_PREF_KEY, "FileSize"));
int index = comboBoxSplitting->findText(fileSizeStr);
Expand All @@ -199,8 +202,7 @@ void DlgPrefRecord::slotResetToDefaults()

// 4GB splitting is the default
comboBoxSplitting->setCurrentIndex(4);
CheckBoxRecordCueFile->setChecked(false);

CheckBoxRecordCueFile->setChecked(kDefaultCueEnabled);
}


Expand Down