Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regressions from CoreServices refactoring #3453

Merged
merged 2 commits into from
Dec 15, 2020
Merged

fix regressions from CoreServices refactoring #3453

merged 2 commits into from
Dec 15, 2020

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Dec 15, 2020

No description provided.

@Be-ing Be-ing mentioned this pull request Dec 15, 2020
Merged
1 task
@uklotzde
Copy link
Contributor

Confirmed. Debug assertions before this PR that are fixed now. LGTM

@uklotzde uklotzde merged commit 648bc1d into mixxxdj:main Dec 15, 2020
@Be-ing
Copy link
Contributor Author

Be-ing commented Dec 15, 2020

It would be great if we could boot and shutdown the whole application on CI to test for debug assertions.

@Be-ing Be-ing deleted the coreservices_regressions branch December 15, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @uklotzde