Drag'n'Drop Analysis #37
Conversation
If you are new to the code the name prepare for everything that is related to the analysisview can be confusing. Renaming them will make it easier to see what the classes are being used for
this path also does some minor code refactoring
| @@ -86,6 +82,23 @@ QString PlaylistDAO::getPlaylistName(int playlistId) | |||
| return name; | |||
| } | |||
|
|
|||
| QList<int> PlaylistDAO::getTrackIds(int playlistId) { | |||
| QSqlQuery query(m_database); | |||
| query.prepare("SELECT track_id from PlaylistTracks WHERE playlist_id = :id"); | |||
There was a problem hiding this comment.
I would do a SELECT DISTINCT because there could be duplicate tracks (even though analyzing twice is a no-op).
|
I made the changes rryan proposed |
|
Thank you @kain88-de! I have just tested your changes and they work fine. Anyhow, your branch is a fine bugfix for the original issue, so lets merge! |
|
The reason all this code is called prepare is because it's unfinished and all it did in V1 of the view was analyze tracks. @asantoni and I envisioned it being a place to go to be a one-stop shop for analyzing, cleaning, and categorizing your library. This would include things like dragging tracks to a crate delegate (the dead code you deleted) for rapid tagging of music, fixing artist/album/genre tags (e.g. normalizing from "DNB", "DrumNBass", "Drum and Bass" to "Drum & Bass") etc. I'd rather we keep it named "Prepare" so that someday when we work on adding those features we won't have to rename it back but since you've already done the work of renaming it we can wait until we add those features to rename it again. |
|
Thanks for the changes -- LGTM |
replace "volume" with "gain" and explain how to adjust gain properly
https://bugs.launchpad.net/mixxx/+bug/1197634
This branch enables to drag'n'drop songs on the analysis view and it is also possible to analysie entire crates/playlists from the submenu. In addition I also renamed all the prepare stuff to analyse so that it is easier to see what these classes are actually used for.