Introduced ControlObjectSlave and converted some controls to this. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ControlObjectSlave connects only on demand and has no "From this signal". Because connect is a static Qt funtion it might be to risky to remove ControlObjectThread yet. ControlObjectSlave should be used in new code.
Merged
|
I would like to merge this soon. Any objections? |
|
paging @rryan to the pull request -- he's the CO architect |
| // Resets the control to its default value. Thread safe, non-blocking. | ||
| virtual void reset(); | ||
|
|
||
| signals: |
There was a problem hiding this comment.
Please add a comment that you must not connect directly but instead should use connectValueChanged.
|
Otherwise, LGTM. Thanks! |
Conflicts: src/engine/enginecontrol.cpp
|
Thank you for review! |
daschuer
added a commit
that referenced
this pull request
Oct 15, 2013
Introduced ControlObjectSlave and converted fist slave Cos to this
illuusio
added a commit
to illuusio/mixxx
that referenced
this pull request
Nov 18, 2014
Merged
11 tasks
daschuer
pushed a commit
that referenced
this pull request
Nov 10, 2019
quantisation fix + cue fix + git-clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next transition of atomic CO.
The main advantage is that the connections are established only when needed.
I did not changed it in ControlObjectThread to avoid change issues.
There are many ControlObjectThread instances where the change signal is not needed. This change will save the set() caller for doing unnecessary checks for possible connections.