Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when right double clicking GLSL waveform #3904

Merged
merged 1 commit into from
May 24, 2021
Merged

Fix crash when right double clicking GLSL waveform #3904

merged 1 commit into from
May 24, 2021

Conversation

poelzi
Copy link
Contributor

@poelzi poelzi commented May 24, 2021

Not sure why m_signalRenderer is even there, since I can't find GLSLWaveformRendererSignal beeing used anywhere,
but m_signalRenderer is definitly nullptr here.

@poelzi poelzi changed the base branch from main to 2.3 May 24, 2021 14:50
@uklotzde uklotzde added this to the 2.3.0 milestone May 24, 2021
uklotzde
uklotzde approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, a hard crash after double right-click which could occur accidentally!

I don't know the original intention. Let's fix the crash as proposed.

LGTM

@uklotzde uklotzde merged commit 99f0a7e into mixxxdj:2.3 May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
blocker critical bug
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@poelzi @uklotzde