Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong current Track fix #4041

Merged
merged 4 commits into from Jul 5, 2021
Merged

Wrong current Track fix #4041

merged 4 commits into from Jul 5, 2021

Conversation

daschuer
Copy link
Member

This fixes an issue that the wrong track is listed in the History.

This fixes a regression since #3500
https://bugs.launchpad.net/mixxx/+bug/1933991

@daschuer daschuer added this to the 2.3.1 milestone Jun 29, 2021
@LeDucDuBleuet
Copy link

I can confirm this fix is working well, the history log is now accurate. Thank you very much for the quick response!

src/mixer/playerinfo.cpp Outdated Show resolved Hide resolved
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
@daschuer
Copy link
Member Author

daschuer commented Jul 2, 2021

Ready.

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect that no other component is waiting for a trackLoaded signal with a nullptr since we also have trackUnloaded. There is even code that handles this special case, e.g. AutoDJCratesDAO::slotPlayerInfoTrackLoaded(). Code like this should probably be cleaned up by a subsequent PR, just to make sure we didn't miss a use case. I'll take care of that.

Thank you! LGTM

@uklotzde uklotzde merged commit 0a6f108 into mixxxdj:2.3 Jul 5, 2021
@uklotzde
Copy link
Contributor

uklotzde commented Jul 5, 2021

@daschuer Maybe this merge was too fast. There are components that only listen to trackLoaded but not the trackUnloaded signal, e.g. BpmControl which expects to receive a trackLoaded(nullptr) signal to reset itself. Not sure if this actually matters.

Those redundant signals cause a mess and need to be cleaned up eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants