Replace trackLoaded and trackUnloaded with a common Track changed signal #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Less than expected. I didn't notice that we have various trackLoaded/trackUnloaded signals. |
|
Why did we merge this to 2.3? It sounds like this fixes not user-facing bug? Shouldn't have this went into |
|
#4041 |
|
Ah OK thanks. I was confused because this PR descriptions says:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #4041 with the suggested common signal.
The pointed out issue with BpmControl is non, because it listens to the caching reader signals directly.
As far as I have tested there was also no issue with the original code.
However this version is less error prone and should save a few CPU cycles.