Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Lock: Fix InternalClock,bpm so it can be used to control overall rate #4135

Merged
merged 1 commit into from
Jul 24, 2021
Merged

Sync Lock: Fix InternalClock,bpm so it can be used to control overall rate #4135

merged 1 commit into from
Jul 24, 2021

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Jul 23, 2021

@ywwg ywwg requested a review from Be-ing July 23, 2021 21:41
@ywwg
Copy link
Member Author

ywwg commented Jul 23, 2021

@Be-ing, this change should fix your issue where changing InternalClock,bpm wasn't affecting playback rate.

@ywwg ywwg force-pushed the synclock-internalclock-ratechanges branch from 155af16 to 0af0d0e Compare July 23, 2021 21:42
@coveralls
Copy link

coveralls commented Jul 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1061096950

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 28.62%
Totals Coverage Status
Change from base Build 1060492554: 0.003%
Covered Lines: 20093
Relevant Lines: 70206
💛 - Coveralls

Be-ing
Be-ing approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as it used to, thanks. I have no comment on the implementation and leave that for someone else to review.

daschuer
daschuer approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@daschuer daschuer merged commit acd63c5 into mixxxdj:main Jul 24, 2021
@daschuer
Copy link
Member

Works also in the double BPM case

@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywwg @coveralls @daschuer @Be-ing