Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID3v2: Fix debug assertion after importing a bpm value of 0 #4154

Merged
merged 1 commit into from
Jul 28, 2021
Merged

ID3v2: Fix debug assertion after importing a bpm value of 0 #4154

merged 1 commit into from
Jul 28, 2021

Conversation

uklotzde
Copy link
Contributor

Code enclosed in if-arm, nothing else changed.

@uklotzde uklotzde added this to the 2.4.0 milestone Jul 27, 2021
@uklotzde uklotzde requested a review from Holzhaus July 27, 2021 21:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1072688793

  • 19 of 25 (76.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 28.615%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/track/taglib/trackmetadata_id3v2.cpp 19 25 76.0%
Totals Coverage Status
Change from base Build 1070910911: 0.002%
Covered Lines: 20086
Relevant Lines: 70194
💛 - Coveralls

@Holzhaus Holzhaus merged commit eefc32f into mixxxdj:main Jul 28, 2021
@uklotzde uklotzde deleted the import-id3v2-bpm branch July 28, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @coveralls @Holzhaus