EngineMaster: Use mixxx::audio::SampleRate #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1109983085
💛 - Coveralls |
uklotzde
reviewed
Aug 8, 2021
|
Why does GitHub still show the changes from #4071 after that PR has been merged? Please rebase or merge main. |
Use `mixxx::audio::SampleRate` instead of `int` in the `EngineMaster`, `EngineSync` and `InternalClock` code. The type was not applied to the channel mixer and effects code to reduce potential merge conflicts with mixxxdj#1966 and mixxxdj#2618. Based on PR mixxxdj#4071.
Holzhaus
force-pushed
the
enginemaster-samplerate-refactor
branch
from
fb98f14
to
c637e39
Compare
|
Thank you for taking care not to interfere with #2618. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
mixxx::audio::SampleRateinstead ofintin theEngineMaster,EngineSyncandInternalClockcode.The type was not applied to the channel mixer and effects code to reduce
potential merge conflicts with #1966 and #2618.
Based on PR #4071.