Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename .desktop file according to Freedesktop standards #4206

Merged
merged 1 commit into from Aug 16, 2021
Merged

rename .desktop file according to Freedesktop standards #4206

merged 1 commit into from Aug 16, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Aug 15, 2021

No description provided.

@Be-ing Be-ing changed the base branch from main to 2.3 August 15, 2021 16:40
@github-actions github-actions bot added the build label Aug 15, 2021
@uklotzde uklotzde added this to the 2.3.1 milestone Aug 15, 2021
@uklotzde uklotzde added changelog This PR should be included in the changelog packaging/installer labels Aug 15, 2021
uklotzde
uklotzde approved these changes Aug 15, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daschuer Anything to do for Debian packaging?

Unrelated: I noticed that the last entry in the changelog is for 2.2.4 although we already released 2.3.0!

@uklotzde
Copy link
Contributor

Seems to comply with the naming conventions: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s02.html

@daschuer
Copy link
Member

@daschuer Anything to do for Debian packaging?

Nothing to do, as long as cmake installs the file to /usr/share/applications

@uklotzde
Copy link
Contributor

@Holzhaus Do you agree with this change?

@Holzhaus
Copy link
Member

@Holzhaus Do you agree with this change?

Yes.

@Holzhaus Holzhaus merged commit 6ccf804 into mixxxdj:2.3 Aug 16, 2021
daschuer added a commit to daschuer/mixxx that referenced this pull request Aug 18, 2021
@daschuer
Added entries about the recent changes mixxxdj#4206 and mixxxdj#4215
a36a5b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
build changelog This PR should be included in the changelog packaging/installer
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Be-ing @uklotzde @daschuer @Holzhaus