Beats: Move identical method implementations from BeatGrid/BeatMap #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
force-pushed
the
beats-common-methods
branch
from
40ec876
to
39fafc0
Compare
This is a first step toward merging the beatgrid/beatmap classes into a single class.
Holzhaus
force-pushed
the
beats-common-methods
branch
from
39fafc0
to
17b9502
Compare
Pull Request Test Coverage Report for Build 1151815857
💛 - Coveralls |
Be-ing
reviewed
Aug 20, 2021
src/track/beats.h
Outdated
| @@ -155,6 +155,10 @@ class Beats { | |||
|
|
|||
| /// Adjust the beats so the global average BPM matches `bpm`. | |||
| virtual BeatsPointer setBpm(mixxx::Bpm bpm) = 0; | |||
|
|
|||
| protected: | |||
| /// For internal use only. | |||
There was a problem hiding this comment.
This comment can be removed. That is clear from the method being protected.
Be-ing
reviewed
Aug 20, 2021
Comment on lines
-146
to
-147
| // This could be implemented in the Beats Class itself. | ||
| // If necessary, the child class can redefine it. |
There was a problem hiding this comment.
Why write this comment instead of just doing it...
There was a problem hiding this comment.
@Be-ing I guess you got confused by the diff? This code and comments have been deleted because they became obsolete.
There was a problem hiding this comment.
I saw that. I am just lamenting that this wasn't already done 10 years ago.
uklotzde
reviewed
Aug 20, 2021
src/track/beatmap.h
Outdated
| @@ -82,7 +79,7 @@ class BeatMap final : public Beats { | |||
| BeatMap(const BeatMap& other); | |||
|
|
|||
| // For internal use only. | |||
There was a problem hiding this comment.
Same here, adding such a comment to a private method is confusing. Unrelated, but let's clean this up now.
uklotzde
approved these changes
Aug 20, 2021
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step toward merging the beatgrid/beatmap classes into a
single class.