Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up: Library prefs #4238

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Follow-up: Library prefs #4238

merged 4 commits into from
Aug 24, 2021

Conversation

uklotzde
Copy link
Contributor

Some trivial changes and cleanup.

Unfortunately, the "[Library]" config group is used for all kinds of settings, not only those that belong to the Library class.

@coveralls
Copy link

coveralls commented Aug 21, 2021

Pull Request Test Coverage Report for Build 1154262831

  • 11 of 16 (68.75%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 25.975%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialog/dlgkeywheel.cpp 0 1 0.0%
src/track/track.cpp 0 1 0.0%
src/widget/wtracktableview.cpp 4 5 80.0%
src/library/library.cpp 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/engine/cachingreader/cachingreaderworker.cpp 2 63.48%
Totals Coverage Status
Change from base Build 1153454756: 0.005%
Covered Lines: 20016
Relevant Lines: 77060

💛 - Coveralls

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@uklotzde
Copy link
Contributor Author

To be discussed: I noticed that ConfigKey is used for addressing both settings and control objects. In this respect we might decide to rename the nested prefs namespace to ctrl or whatever is more suitable to cover all use cases.

@Be-ing Be-ing merged commit f2258d1 into mixxxdj:main Aug 24, 2021
@uklotzde uklotzde deleted the library_prefs branch September 4, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants