do not assume PortAudio on Linux was built with ALSA backend #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
force-pushed
the
portaudio_no_alsa
branch
from
450141f
to
f472ab2
Compare
Be-ing
commented
Aug 25, 2021
Comment on lines
+86
to
+89
| if(PortAudio_ALSA_H) | ||
| target_compile_definitions(PortAudio::PortAudio INTERFACE PA_USE_ALSA) | ||
| endif() |
There was a problem hiding this comment.
This should be handled by PortAudio's build system. I opened a PR upstream to implement that: PortAudio/portaudio#635
uklotzde
suggested changes
Aug 25, 2021
|
Rebase on and target 2.3? |
🤷 I don't really care either way. AFAIK this issue only affects me. |
Be-ing
force-pushed
the
portaudio_no_alsa
branch
from
f472ab2
to
3ac09c1
Compare
|
There are significant conflicts rebasing this onto 2.3 and I don't really care to resolve them. |
uklotzde
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hack around a PipeWire bug:
https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1547