BeatsImporter: Return Beats object instead of frame position vector #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the BeatsImporter return an actual Beats object instead of a vector of frame positions. The main reason for this change is that it will avoid the unnecessary intermediate step of converting to/from raw frame positions when the new beats implementation is ready. Additionally, this prevents wrong usage by making it impossible to passing a `SignalInfo` to import method and then use a different sample rate for creating the beats object (which would invalidate all positions). Theoretically, this also allows to return a `BeatGrid` instead of a `BeatMap`, although we don't make use of this possibility and the distinction hopefully becomes obsolete soon anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the BeatsImporter return an actual Beats object instead of a
vector of frame positions. The main reason for this change is that it
will avoid the unnecessary intermediate step of converting to/from raw
frame positions when the new beats implementation is ready.
Additionally, this prevents wrong usage by making it impossible to
passing a
SignalInfoto import method and then use a different samplerate for creating the beats object (which would invalidate all
positions).
Theoretically, this also allows to return a
BeatGridinstead of aBeatMap, although we don't make use of this possibility and thedistinction hopefully becomes obsolete soon anyway.