Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParserM3u: rewrite for Qt6 compatibility #4418

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 14, 2021

QTextStream no longer supports uncommon encodings like Windows-1250
in Qt6:
https://bugreports.qt.io/browse/QTBUG-75665

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor suggestion.

Should we extract all the string constants that are scattered throughout the code? At least extracting kWindowsEncoding would help.

src/library/parserm3u.cpp Outdated Show resolved Hide resolved
@Be-ing Be-ing force-pushed the parserm3u_rewrite branch 5 times, most recently from 1d8cde4 to dccdc4b Compare October 14, 2021 09:38
src/library/parserm3u.cpp Outdated Show resolved Hide resolved
src/library/parserm3u.cpp Outdated Show resolved Hide resolved
QTextStream no longer supports uncommon encodings like Windows-1250
in Qt6:
https://bugreports.qt.io/browse/QTBUG-75665
@Be-ing Be-ing merged commit a006552 into mixxxdj:main Oct 14, 2021
@Be-ing Be-ing deleted the parserm3u_rewrite branch October 14, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants