Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: lower compiler cache size to 0.5 GB #4452

Merged
merged 1 commit into from Oct 19, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 17, 2021

Hopefully this will result in less frequent cache misses.

@Be-ing Be-ing marked this pull request as draft October 17, 2021 13:43
@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 17, 2021

2 GB * 3 operating systems * 2 (Qt5 + Qt6) > 5 GB

@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 17, 2021

Here is a run with all cache misses. The sizes of the compiler caches uploaded to GitHub Actions were:

  • Ubuntu: 376 MB
  • macOS: 211 MB
  • Windows: 263 MB

So I think 512 MB is sufficient.

@Be-ing Be-ing marked this pull request as ready for review October 17, 2021 14:21
@@ -199,8 +199,8 @@ jobs:
BUILDENV_BASEPATH: ${{ matrix.buildenv_basepath }}

- name: "[Ubuntu/macOS] Set compiler cache size limit"
# Set size to 2 GiB
run: ${{ matrix.compiler_cache }} -M 2097152
# Set size to 512 MiB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment why this particular value has been chosen, i.e. the calculation from the PR description? Prefer to add important information directly to the code instead of only mentioning it in the PR.

Hopefully this will result in less frequent cache misses.
@Holzhaus Holzhaus merged commit b077d80 into mixxxdj:main Oct 19, 2021
@Be-ing Be-ing deleted the cache_size branch October 19, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants