Fix segfault when starting without a valid skin directory #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
Dec 21, 2021
src/mixxx.cpp
Outdated
| m_pSettingsManager->settings()->set(ConfigKey("[MainWindow]", "state"), | ||
| QString(saveState().toBase64())); | ||
| UserSettingsPointer pSettings; | ||
| if (m_pSettingsManager) { |
There was a problem hiding this comment.
Und which circumstances can Settings Manager or Settings be null?
There was a problem hiding this comment.
Ah I see due to later commits, it can no longer be null. I will revert that.
There was a problem hiding this comment.
I hope it is OK to just drop the commit when rebasing.
|
Done. Ready for merge? |
Holzhaus
approved these changes
Jan 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
https://bugs.launchpad.net/mixxx/+bug/1934560