Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID3v2 parsing: Improve readability and log warnings #4610

Merged
merged 4 commits into from
Jan 16, 2022
Merged

ID3v2 parsing: Improve readability and log warnings #4610

merged 4 commits into from
Jan 16, 2022

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Jan 8, 2022

  • Log warnings when encountering unknown or unexpected frames
  • Linearize code structure to improve readability

@uklotzde
Copy link
Contributor Author

Ping

Holzhaus
Holzhaus approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Holzhaus Holzhaus merged commit e27e48c into mixxxdj:main Jan 16, 2022
@uklotzde uklotzde deleted the taglib-id3v2 branch January 16, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y left review comments

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @Holzhaus @Swiftb0y