-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CmdLine: show native path separators in --help #4657
Conversation
Translations are synchronized with Transifex once in a while, not manually. https://github.com/mixxxdj/mixxx/wiki/Internationalization#developers---i18nl10n-and-mixxx |
Didn't notice that there are 2 commits. Please revert all changes of .ts files. |
As a First-time Contributor we have to ask you to sign our Contributor Agreement (follow this link) before we can merge any code. ✔️ |
Thanks, I'm a bit rusty. I think I reverted those properly and the only file being changed should be the .cpp now |
Next time please stash the changes and then force push to eliminate those extra commits. This is a special case were a force push is accepted and desired. |
@uklotzde meant squash, not stash. If you're interested, you can find a description how that works here: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History No need to do this now, we just use the squash-and-merge strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you. Did you already sign the CLA?
That's taken care of, thanks for the reminder. |
@motific, I like to add you to the contributor list in the Mixxx About Box. Shall I use your GitHub User name or your real name? |
Hi Daniel,
You can use my real name, James Snell
Thanks for checking!
From: Daniel Schürmann ***@***.***>
Sent: 15 June 2022 21:34
To: mixxxdj/mixxx ***@***.***>
Cc: motific ***@***.***>; Mention ***@***.***>
Subject: Re: [mixxxdj/mixxx] CmdLine: show native path separators in --help (PR #4657)
@motific <https://github.com/motific> , I like to add you to the contributor list in the Mixxx About Box. Shall I use your GitHub User name or your real name?
—
Reply to this email directly, view it on GitHub <#4657 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUXNB3FPQNVT6UZ6CPUI4UTVPI4Z5ANCNFSM5NI53VWA> .
You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AUXNB3DOP4MWXSC56CJS2LTVPI4Z5A5CNFSM5NI53VWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIT2PBZQ.gif> Message ID: ***@***.*** ***@***.***> >
|
Translation source changed in cmdLineArgs.cpp line 134