Rewrited usage of QSqlRecord. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoided multiple creation of QSqlRecord (on calls query-
| @@ -93,9 +93,10 @@ Cue* CueDAO::getCue(const int cueId) { | |||
| query.prepare("SELECT * FROM " CUE_TABLE " WHERE track_id = :id"); | |||
| query.bindValue(":id", trackId); | |||
| if (query.exec()) { | |||
| const int idColumn = query.record().indexOf("id"); | |||
There was a problem hiding this comment.
Could you do this before the exec()? QSqlRecord copies all the values if you call query.record() after exec()'ing the query.
There was a problem hiding this comment.
Nevermind! If the record() call comes before next() then it doesn't point to a valid row so there's no data to copy. It's fine as is.
|
@rryan take a look at new commit, please. |
|
Looks good! Thank you @troyane |
rryan
added a commit
that referenced
this pull request
Jul 17, 2013
Fix use of QSqlQuery::record() to reduce excessive copying of result rows. Fixes Bug #1201991.
11 tasks
ronso0
referenced
this pull request
in ronso0/mixxx
Jan 20, 2020
merge master, adapt to LateNight redesign
daschuer
pushed a commit
that referenced
this pull request
Jul 8, 2020
Replace Master by Main in the Shade main mixing region
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
Update beta link to RC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoided multiple creation of QSqlRecord and pulled out record->indexOf's from cycles.