Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into coherent PromiseResolver async/await issue #1

Closed
mizx opened this issue Sep 28, 2017 · 3 comments
Closed

Look into coherent PromiseResolver async/await issue #1

mizx opened this issue Sep 28, 2017 · 3 comments
Assignees

Comments

@mizx
Copy link
Owner

mizx commented Sep 28, 2017

Coherent GT uses an older implementation of Promise which is different than the finalized ES6 one.

https://forums.coherent-labs.com/index.php?topic=1184.0

This causes problems when using async/await and gives the following error in coherent:
PromiseResolver is not a function (evaluating 'resolve(result.value)')

Including bluebird solves the problem but I'd rather not include bluebird just to get around this.

@mizx mizx self-assigned this Sep 28, 2017
@mizx
Copy link
Owner Author

mizx commented Sep 29, 2017

Coherent's Promise object doesn't initialize until after the react App component mounts to DOM. Had to put in a hack: c95552c

@mizx
Copy link
Owner Author

mizx commented Oct 4, 2017

Considering this a non-issue. RXJS fromPromise seems to handle both Chrome and Coherent Promises just fine.

@mizx mizx closed this as completed Oct 4, 2017
@mizx
Copy link
Owner Author

mizx commented Oct 18, 2017

Future version of coherent will have standard version of Promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant