Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Comments #100

Merged
merged 24 commits into from
Mar 19, 2022
Merged

Support Comments #100

merged 24 commits into from
Mar 19, 2022

Conversation

mjakeman
Copy link
Owner

@mjakeman mjakeman commented Feb 5, 2022

Work in progress support for displaying comments alongside extension listings.

Fixes #4

TODO:

  • Do not use homogenous sizing for tiles
  • Display author name
  • Display rating (preferably as star count?)
  • Investigate ellipsizing when over a certain height/ratio not worth the effort at the point
  • Add spinner while loading comments
  • Option to show more comments on click
  • Are comments sorted by most recent? looks like it, but we have no control anyway
  • Clear display when opening a different extension listing
  • Fix ridiculous gridview padding Switched back to flowbox
  • Needs a (pre-)release of text-engine
  • Comments dialogue freezes after accessing for second extension
  • Connect comments dialogue to correct web_id

image

@mjakeman
Copy link
Owner Author

Taking a break from working on this while awaiting clarification about the grid view sizing issue. This is still planned as the main feature for 0.3

@mjakeman mjakeman mentioned this pull request Mar 15, 2022
@mjakeman
Copy link
Owner Author

Some new screenshots...

Detail page design:

image

Comments dialog:

image

@mjakeman
Copy link
Owner Author

This is now complete, awaiting a (pre?)release of text-engine.

With ratings implemented:

image

@mjakeman mjakeman marked this pull request as ready for review March 19, 2022 10:19
@mjakeman mjakeman enabled auto-merge March 19, 2022 10:20
@mjakeman mjakeman merged commit 98e2aca into master Mar 19, 2022
@mjakeman mjakeman deleted the comments branch March 19, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments and Ratings
1 participant