Skip to content
This repository has been archived by the owner on Mar 16, 2020. It is now read-only.

j/k should set feed at the top #37

Open
maddyblue opened this issue Jun 28, 2013 · 2 comments
Open

j/k should set feed at the top #37

maddyblue opened this issue Jun 28, 2013 · 2 comments

Comments

@maddyblue
Copy link
Owner

No description provided.

@wscott
Copy link

wscott commented Jun 29, 2013

I am not so sure that is always true. I have a "deals" folder where I subscribe to slickdeals.net and spoofee deals. These RSS feeds are one line articles where all the information is in the article. For that scrolling every time making it harder to track visually.

I would propose that if the article doesn't fit or takes up more than 50% of the screen then it should scroll to the top.

@ericu
Copy link

ericu commented Dec 3, 2013

There's some sense to that, although I'd probably set the cutoff lower than 50%.

There's a specific failure case that keeps hitting me, though:
* You have an article that's longer than a page.
* You hit space some number of times to see the rest of it.
* The next article appears at the bottom of the page, partly shown.
* You hit 'j', expecting it to move to the top.
* Instead, that article gets skipped entirely, and the third article appears at the top.

I believe this happens because GoRead marks the second article as read as soon as it appears. I think that's the wrong behavior; if it just delayed that marking until the next 'j', it would probably just work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants