Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose: SQL or CockroachDB-flavored SQL? #53

Open
pauldraper opened this issue Mar 14, 2020 · 1 comment
Open

Purpose: SQL or CockroachDB-flavored SQL? #53

pauldraper opened this issue Mar 14, 2020 · 1 comment

Comments

@pauldraper
Copy link

pauldraper commented Mar 14, 2020

This library uses the CockroachDB SQL parser, which effectively limits it to use with just CockroachDB, since CockroachDB lacks significant amounts of SQL support: WITH RECURSIVE, CREATE FUNCTION, and CREATE TYPE. And that's just standard ANSI SQL.

IMO, this should either

  1. advertise as CockroachDB SQL formatter

  2. fork from the CockroachDB parser so as to allow contributions to support SQL syntax (regardless of CockroachDB support).

@maddyblue
Copy link
Owner

I agree, we should do 1 and put a notice somewhere on the website. I'll keep this open until that gets done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants