Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate .MJML extension with MJML app #144

Closed
dshastry opened this issue Jun 2, 2017 · 4 comments
Closed

Associate .MJML extension with MJML app #144

dshastry opened this issue Jun 2, 2017 · 4 comments
Labels
Milestone

Comments

@dshastry
Copy link

dshastry commented Jun 2, 2017

MacOS Sierra does not recognize *.mjml files to be associated with the MJML app. It's confusing at times for new users because they expect to be able to open a project by double clicking the index.mjml file however, the file type shows up as unrecognized.

Binding the *.mjml filetype to open with the MJML app would solve this issue.

@meriadec
Copy link
Contributor

meriadec commented Jun 6, 2017

Would be cool but not so easy to do.
some clues on Atom repo electron/electron#5369

@dshastry
Copy link
Author

dshastry commented Jun 6, 2017

Just checked out the referenced thread in the atom repo and it looks like the plist has to be ammended, no? Essentially just adding this block :

	<dict>
		<key>CFBundleTypeExtensions</key>
		<array>
			<string>markdown</string>
			<string>mdown</string>
			<string>markdn</string>
			<string>md</string>
		</array>
		<key>CFBundleTypeIconFile</key>
		<string>file.icns</string>
		<key>CFBundleTypeName</key>
		<string>Markdown document</string>
		<key>CFBundleTypeRole</key>
		<string>Editor</string>
		<key>LSHandlerRank</key>
		<string>Alternate</string>
	</dict>

Could you not add that into the application plist when you package the DMG?

@meriadec
Copy link
Contributor

meriadec commented Jun 6, 2017

Yeah, sometimes things looks easy on the outside 😄 I'm not really used to DMG / osx package system. Also, we have not currently any plist file in the repo. And the feature should also work in Windows to be complete.

If you have any hints, can you make a PR for that?

@dshastry
Copy link
Author

dshastry commented Jun 7, 2017

Yup. I'll pull and try to tackle. Ping back shortly

@meriadec meriadec added next and removed request labels Mar 7, 2018
@meriadec meriadec added this to the 2.9.0 milestone Mar 7, 2018
meriadec added a commit that referenced this issue Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants