-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App does not quit #267
Comments
relatable: Line 90 in 12f997f
|
@meriadec so should we just remove this check and close the app anyway ? |
Furthermore you cannot quit the app by right-clicking the dock icon and selecting 'quit', it just ignores the command. |
@kmcb777 yep go ahead 👍 i always have found this osx behaviour stupid |
Describe the bug
The application does not terminate upon closing it. Trying to open it again results in a "This application is not open anymore" error. It needs to be force quit every time from the top left apple icon menu.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The application quits normally.
Video recording
http://files.wild.as/5Pirue
Environment (please complete the following information):
I tried to lookup the version number while in the "Closed but still running" state and the about window showed this up. I figured it might help.
A JavaScript error occurred in the main process
Uncaught Exception: Error: Object has been destroyed at mainWindow (/Applications/MJML.app/Contents/Resources/app.asar/webpack:/src/menu.js:26:13) at MenuItem.click (/Applications/MJML.app/Contents/Resources/electron.asar/browser/api/menu-item.js:52:9) at Function.executeCommand (/Applications/MJML.app/Contents/Resources/electron.asar/browser/api/menu.js:34:15)
The text was updated successfully, but these errors were encountered: