Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App does not quit #267

Closed
ParallelUniv3rse opened this issue Oct 9, 2018 · 4 comments
Closed

App does not quit #267

ParallelUniv3rse opened this issue Oct 9, 2018 · 4 comments

Comments

@ParallelUniv3rse
Copy link

Describe the bug
The application does not terminate upon closing it. Trying to open it again results in a "This application is not open anymore" error. It needs to be force quit every time from the top left apple icon menu.

To Reproduce
Steps to reproduce the behavior:

  1. Open the application
  2. Try to quit - doesn't work
  3. Close the application's window
  4. The app still seems to be running in the dock, but clicking does nothing
  5. Launch from spotlight produces the mentioned error.

Expected behavior
The application quits normally.

Video recording
http://files.wild.as/5Pirue

Environment (please complete the following information):

  • OS: MacOS High sierra & Mojave, experienced the error on both.
  • App Version 2.10.0

I tried to lookup the version number while in the "Closed but still running" state and the about window showed this up. I figured it might help.

A JavaScript error occurred in the main process
Uncaught Exception: Error: Object has been destroyed at mainWindow (/Applications/MJML.app/Contents/Resources/app.asar/webpack:/src/menu.js:26:13) at MenuItem.click (/Applications/MJML.app/Contents/Resources/electron.asar/browser/api/menu-item.js:52:9) at Function.executeCommand (/Applications/MJML.app/Contents/Resources/electron.asar/browser/api/menu.js:34:15)

@meriadec
Copy link
Contributor

meriadec commented Oct 9, 2018

relatable:

if (process.platform !== 'darwin') {

@kmcb777
Copy link
Contributor

kmcb777 commented May 20, 2019

@meriadec so should we just remove this check and close the app anyway ?
It's indeed a bit annoying that the mjml app icon stays in the doc, clicking it doesn't open the app

@punqbund
Copy link

Furthermore you cannot quit the app by right-clicking the dock icon and selecting 'quit', it just ignores the command.
Annoying is also that the running mjml app is preventing the shutdown of the Mac. In order to complete the shutdown procedure you need to focus the app and then manually quit it via the top menu or by ⌘+Q.

@meriadec
Copy link
Contributor

@kmcb777 yep go ahead 👍 i always have found this osx behaviour stupid

iRyusa added a commit that referenced this issue Jul 2, 2019
#278 save window settings, #267 close app when close window on mac
@iRyusa iRyusa closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants