Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac app window does not remember set size, resets too small #278

Closed
ciaw opened this issue Feb 18, 2019 · 3 comments
Closed

Mac app window does not remember set size, resets too small #278

ciaw opened this issue Feb 18, 2019 · 3 comments

Comments

@ciaw
Copy link

ciaw commented Feb 18, 2019

Describe the bug
The MJML app (Mac) does not remember window size. Every time the window is closed or the app is relaunched, it comes back in a window that is roughly 800x580px.

The size is fine for the list of projects screen, however, the small size is maintained when you open a project so the coding area is extremely narrow and unusable until you manually resize the window again.
screen shot 2019-02-18 at 3 00 33 pm
To Reproduce

  1. Close window or quit app.
  2. Relaunch app again, or click on dock icon while still opened to bring up a new window.

Environment (please complete the following information):

  • OS: macOS Mojave 10.14.3
  • App Version: v2.10.0
@meriadec
Copy link
Contributor

Size could be saved and restored here:

const w = new BrowserWindow({
webPreferences: {
webSecurity: false,
},
backgroundColor: '#2A2A35',
show: false,
})

I worked on something similar in ledger-live-desktop.

iRyusa added a commit that referenced this issue Jul 2, 2019
#278 save window settings, #267 close app when close window on mac
@jbickelhaupt
Copy link
Contributor

If it'd be easier, what about setting a default size of 100% of the available screen size? I'd be OK with that solution…

@kmcb777
Copy link
Contributor

kmcb777 commented Sep 12, 2019

@jbickelhaupt unfortunately size can only be set in px
In latest version, the app saves the size of the window on close and restore it on start (also the position on osx)

@iRyusa iRyusa closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants