Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion providers #17

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

Daniel-Knights
Copy link

What

Add support for:

  • Attribute completion within opening tags
  • CSS property/value completion within mj-style tags
  • HTML tag completion within mj-text tags

How

Create a new Completion class that utilises VSCode's registerCompletionItemProvider and add a folder with the necessary snippets.

Examples

Attribute completion within opening tags

ezgif com-gif-maker

CSS property/value completion within mj-style tags

ezgif com-gif-maker (1)

HTML tag completion within mj-text tags

ezgif com-gif-maker (2)

@iRyusa
Copy link
Member

iRyusa commented May 6, 2021

Looks good to me @kmcb777 can we release that ?
We'll see if we can improve it by using component definition later

@kmcb777 kmcb777 merged commit 4d757e0 into mjmlio:master Jul 21, 2021
@dnuanes
Copy link

dnuanes commented Jul 27, 2021

Hey Daniel, thanks for the PR. This is a fantastic feature.

@Daniel-Knights
Copy link
Author

Hey, thanks @dnuanes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants