Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on removing Javascript requirements? #65

Open
wgordon17 opened this issue Oct 5, 2022 · 2 comments
Open

Thoughts on removing Javascript requirements? #65

wgordon17 opened this issue Oct 5, 2022 · 2 comments

Comments

@wgordon17
Copy link

Understandably, some of the MFA methods rely on Javascript, however for those users not interested in relying on Javascript, we should still be able to support methods like TOTP, email, etc without requiring Javascript.

Would you be open to having fallbacks?

@mkalioby
Copy link
Owner

mkalioby commented Oct 5, 2022

Can you be more specific? Which js files are talking about exactly? Totp needs Js to render the QR code.

@wgordon17
Copy link
Author

wgordon17 commented Oct 5, 2022

I actually didn't realize that. Just wondering (and not really a priority, just gauging importance from other folks) if a lot of this could be handled without Javascript, and rely on Javascript as an enhancement? For instance, would it be possible to move QR code generation to server-side? Or, instead of AJAX for toggling/removing methods in MFA.html, use regular submit buttons ¯\_(ツ)_/¯

And maybe that's not the goal of this package, relying on developers to just override the templates if they want to remove Javascript. But I felt like it could be a valid enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants