Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normals - inward or outward? #289

Closed
jaquilio opened this issue Dec 20, 2023 · 1 comment
Closed

Normals - inward or outward? #289

jaquilio opened this issue Dec 20, 2023 · 1 comment

Comments

@jaquilio
Copy link

In Kazdan et al's 2006 "Poisson Surface Reconstruction" paper, normals are assumed to be pointing inward. But, does the code actually assume the opposite, i.e., that they are pointing outward?

I got that impression by the response to the following issue: #121

Also, in the discussion of a couple of issues (e.g., #214), I saw the comment saying "the dot-product of the view direction and the surface normal must be negative". Following the usual convention of taking the view direction to be the vector from the view point to the scene point, for that condition to hold, the surface normal should be facing outward.

@jaquilio jaquilio changed the title Normals - inward, outward? Normals - inward or outward? Dec 20, 2023
@mkazhdan
Copy link
Owner

In the code code, the normals are assumed to be pointing outward. They are flipped in the code so that the indicator function changes from 0 (outside) to 1 (inside.).

It should not make a difference using the default settings. However, if you use Dirichlet boundary conditions (instead of the default Neumann conditions) or use an envelope, the results will be different depending on whether normals are inward or outward facing..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants