Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table style is lost #106

Closed
javenfang opened this issue Jul 18, 2014 · 10 comments · Fixed by #257
Closed

table style is lost #106

javenfang opened this issue Jul 18, 2014 · 10 comments · Fixed by #257

Comments

@javenfang
Copy link

snip20140718_2

No table style is applied.
Same effect even switch to other template.
@Hernrup
Copy link
Contributor

Hernrup commented Jul 18, 2014

Solved in PR #59.
Hopefully @tomchristie will get some time off to verify and pull it in the next weeks.

@fedelibre
Copy link
Contributor

Yes, tables don't look good. See also MkDocs documentation:
http://www.mkdocs.org/user-guide/configuration/

@tomchristie
Copy link
Member

Looks like PR #59 is still waiting on updates - if anyone wants to take that on it'd help push this issue along.

@Hernrup
Copy link
Contributor

Hernrup commented Nov 4, 2014

I am having trouble getting the time to fix the last issues. If someone
ells wants to take it further I would support that.

Med vänliga hälsningar

Mikael Hernrup
0736-850768
Mikael@Hernrup.se

On Mon, Nov 3, 2014 at 2:23 PM, Tom Christie notifications@github.com
wrote:

Looks like PR #59 #59 is
still waiting on updates - if anyone wants to take that on it'd help push
this issue along.

—
Reply to this email directly or view it on GitHub
#106 (comment).

@kostajh kostajh mentioned this issue Nov 5, 2014
Closed
@drewvanstone
Copy link

+1

@drewvanstone
Copy link

Any update on this issue? I wish I knew how to fix it myself, but unfortunately am not familiar with this domain. I find tables to be one of the most useful aspects of wiki's, and unfortunately in it's current state most of the usefulness of mkdocs is lost at the moment. I'd love to see a fix for this in any of the themes. I'm trying to sell our team on using mkdocs for our wiki, but can't until this is fixed.

@d0ugal
Copy link
Member

d0ugal commented Nov 16, 2014

The changes in #59 fixes this for the Read The Docs theme. I've rebased this changed and started doing updates on it in #225.

The MkDocs theme still has this issue.

@tomchristie tomchristie mentioned this issue Nov 17, 2014
Closed
@DannyBen DannyBen mentioned this issue Nov 27, 2014
Closed
@d0ugal
Copy link
Member

d0ugal commented Nov 28, 2014

The changes in #225 are now merged, so this should be resolved.

@d0ugal d0ugal closed this as completed Nov 28, 2014
@fedelibre
Copy link
Contributor

They are solved in the mkdocs theme, not in RTD theme. Please double check

@d0ugal d0ugal reopened this Nov 30, 2014
d0ugal added a commit to d0ugal/mkdocs that referenced this issue Nov 30, 2014
@d0ugal
Fix rendering of tables in the Read The Docs theme
294b788 
For the Read The Docs theme to render tables correctly it expects them
to have the docutils class (which is present in Sphinx projects).

Fixes mkdocs#106
@d0ugal
Copy link
Member

d0ugal commented Nov 30, 2014

Good point, sorry, got my wires crossed.

@d0ugal d0ugal mentioned this issue Nov 30, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rendering of tables in the Read The Docs theme d0ugal/mkdocs
6 participants
@d0ugal @javenfang @tomchristie @drewvanstone @fedelibre @Hernrup