Stopped Working for Me in Firefox Nightly (36) on Arch Linux

[MichaelTunnell]

This extension is fantastic when it is working..Firefox's notifications get in the way a LOT especially if you setup PushBullet to provide Android notifications in your Firefox (awesome but gets overbearing).

I installed this extension on Firefox Nightly 35 and it worked GREAT but then I updated to Nightly 36 and it does not seem to work at all anymore.

I am using Firefox Nightly (36) on Arch Linux with GNOME Shell 3.14 and libnotify 0.7.6. - I am fairly certain it worked fine with GNOME 3.14 before the upgrade to Nightly 36. As of now, none of the notifications are being sent to libnotify, not even the basic download completed messages.

I realize it could be an Arch specific issue because those seem to be frequent with Nightly but just in case I am posting this issue on the chance that it isnt Arch related.

[mkiol]

Thanks for the report. I will take a look into it during weekend.

[mkiol]

Unfortunately, so far I was unable to confirm the issue. I did tests using firefox-36.0a1.en-US.linux-x86_64.tar.bz2 and everything seems to work fine. Maybe it is something Arch related.

If you are determined enough then I suggest you to do observation with preferences option extensions.sdk.console.logLevel = all (see "Setting the Logging Level" section on https://developer.mozilla.org/en-US/Add-ons/SDK/Tools/console). If you run FF from command line, there should be some debugging information.

Additionally, here is Gnotifier release with more verbose logging enabled.

[tatokis]

I think I am having the same issue but with Nightly 37. It has been happening for some time here as well.
I set "extensions.sdk.console.logLevel = all" on about.config and also installed the Gnotifier with the debugging.
On Nightly start up there weren't any error messages related to Gnotifier.
Starting a download printed the following

WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
internalPersist@chrome://global/content/contentAreaUtils.js:381:19
continueSave@chrome://global/content/contentAreaUtils.js:328:5
internalSave/<@chrome://global/content/contentAreaUtils.js:301:7
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
console.log: gnotifier: onDownloadChange

Looking at the console.error output though, seems to reveal this

console.error: gnotifier: 
  Message: InternalError: too much recursion
  Stack:
    AddonInterpositionService.prototype.interpose/desc.value@resource://gre/components/multiprocessShims.js:127:52
ComponentRegistrarInterposition.methods.unregisterFactory@resource://gre/modules/RemoteAddonsParent.jsm:272:5
AddonInterpositionService.prototype.interpose/desc.value@resource://gre/components/multiprocessShims.js:127:52
ComponentRegistrarInterposition.methods.unregisterFactory@resource://gre/modules/RemoteAddonsParent.jsm:272:5
AddonInterpositionService.prototype.interpose/desc.value@resource://gre/components/multiprocessShims.js:127:52
ComponentRegistrarInterposition.methods.unregisterFactory@resource://gre/modules/RemoteAddonsParent.jsm:272:5
AddonInterpositionService.prototype.interpose/desc.value@resource://gre/components/multiprocessShims.js:127:52
ComponentRegistrarInterposition.methods.unregisterFactory@resource://gre/modules/RemoteAddonsParent.jsm:272:5

With the last two lines repeating a lot of times

[mkiol]

I can confirm. Having the same issue in Nightly 37. Fortunately, in FF 35 and 36, everything seams to work fine.

That is the code that caused the exception: https://github.com/mkiol/GNotifier/blob/master/lib/main.js#L307-311.

Honestly, I have no clue why it doesn’t work :/

[tatokis]

I commented out the lines you mentioned, reinstalled the plugin, but I still see the "too much recursion" error on the console. Unless, of course, you are talking about something else and the "too much recursion" error is not related

[mkiol]

My mistake, both unregisterFactory and registerFactory are causing error: https://github.com/mkiol/GNotifier/blb/master/lib/main.js#L307-319. Unfortunately, this part of code is essential. Gnotifier will not work without it.

[MichaelTunnell]

Ok, I am not sure what all changed but my combination is now working again.

GNotifier 1.8.7
firefox-nightly 37.0a1.20141225-1
libnotify 0.7.6-1
gnome-shell 3.14.2-1
linux 3.17.4-1

[tatokis]

Unfortunately, it is still not working for me.
GNotifier 1.8.7 - Debug Version
Nightly 37.0a1(SourceStamp=6530bfc2636e)
libnotify 0.7.6-1ubuntu3
unity 7.3.1
3.19.0-031900rc1

[MichaelTunnell]

@tatokis it looks like it could be because you are using such a bleeding edge kernel. Try using 3.17 or 3.18 and see if it works then . . . if so then it could be narrowed down at that point.

[tatokis]

@MichaelTunnell

$ uname -r
3.17.4-031704-generic

I installed 3.17.4 from the ubuntu kernel repository.
Unfortunately it doesn't look like this is the issue.

[Rob--W]

@mkiol I encountered the recursion error in my addon as well, and fixed it in this way: Rob--W/nnnotifier@933c4ae. Perhaps you want to apply and test a similar fix.

I've reported the bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1141070.

[mkiol]

@Rob--W @tatokis Thanks, finally I can close this issue :-)

[MichaelTunnell]

Very Cool, thanks for sharing the fix @Rob--W !