Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated imported waves #2

Closed
GoogleCodeExporter opened this issue Aug 6, 2015 · 6 comments
Closed

Duplicated imported waves #2

GoogleCodeExporter opened this issue Aug 6, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Import a wave from Google Wave
2. Make sure the wave hasn't been modified in Google Wave
3. Import it again in Walkaround (intentionally or not)

What is the expected output? 
The wave shouldn't be imported again if it hasn't been modified since the last 
import.

What do you see instead?
The wave is imported 2 times in Walkaround, with 2 different waveIDs, despite 
being totally identical.

The fault is essentially to the user since the import action has been performed 
twice, but I think there should be a "security" to avoid duplicates: If the 
user doesn't realize his wave has been imported (because the GWave original 
title doesn't appear in the Walkaround inbox for example), trying to import it 
again could be a common mistake. When the wave is 100% identical I think it 
shouldn't be imported again.

What version of the product are you using? On what operating system?
Demo server at wavereactor.appspot.com
Windows XP , Google Chrome


Original issue reported on code.google.com by jeremy.ngl on 5 Nov 2011 at 2:26

@GoogleCodeExporter
Copy link
Author

A way to delete a wave imported in Walkaround would also do the trick.

Original comment by jeremy.ngl on 28 Nov 2011 at 9:57

@GoogleCodeExporter
Copy link
Author

The way to delete a wave is to remove all participants.  Currently, this just 
leaves the wave inaccessible, and the data remains in the datastore; but that 
difference is not user-visible.  The longer-term plan is to do a periodic 
cleanup.

I agree that avoiding duplicates would be good, but I think we should only do 
this once Google Wave is read-only.  Then, we can be certain that the original 
never changes.

Original comment by oh...@google.com on 28 Nov 2011 at 7:04

@GoogleCodeExporter
Copy link
Author

Original comment by oh...@google.com on 2 Dec 2011 at 8:20

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Original comment by oh...@google.com on 4 Jan 2012 at 12:35

  • Added labels: Component-Import

@GoogleCodeExporter
Copy link
Author

Original comment by oh...@google.com on 13 Jan 2012 at 7:29

@GoogleCodeExporter
Copy link
Author

Fixed in http://code.google.com/p/walkaround/source/detail?r=18fb56a50e8d .

Original comment by oh...@google.com on 24 Jan 2012 at 4:02

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant