Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with limiting_slopes #2

Closed
fserra opened this issue Aug 1, 2016 · 2 comments
Closed

problem with limiting_slopes #2

fserra opened this issue Aug 1, 2016 · 2 comments

Comments

@fserra
Copy link

fserra commented Aug 1, 2016

Hi
There seems to be a bug in limiting_slopes:

sage: limiting_slopes(gmic(f=0.66666666))
INFO: 2016-08-01 16:20:58,542 Rational case.
(50000000/33333333, -Infinity)
sage: limiting_slopes(gmic(f=0.666666666))
INFO: 2016-08-01 16:22:48,343 Rational case.
(499999997/333333331, -499999973/166666658)
@mkoeppe
Copy link
Owner

mkoeppe commented Aug 1, 2016

Try to coerce f to rationals by using QQ(0.66666666).
The code is not floating point safe.

On Monday, August 1, 2016, fserra notifications@github.com wrote:

Hi

There seems to be a bug in limiting_slopes:

sage: limiting_slopes(gmic(f=0.66666666))
INFO: 2016-08-01 16:20:58,542 Rational case.
(50000000/33333333, -Infinity)
sage: limiting_slopes(gmic(f=0.666666666))
INFO: 2016-08-01 16:22:48,343 Rational case.
(499999997/333333331, -499999973/166666658)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH9WhfFFlTPFZiip5Cc8h8pOyWPc6eKeks5qbgGEgaJpZM4JZoxq
.

Sent from my phone

@fserra
Copy link
Author

fserra commented Aug 1, 2016

great, that solves the issue, thanks!

@fserra fserra closed this as completed Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants