Port j quoted strings interpolation from Melange
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
changed the title
j and js quoted stringsj quoted strings interpolation from Melange
|
After trying the original approach in this PR (not support The solution then to have "universal unicode strings" has switched to supporting Quoted strings with |
|
Discussed with @davesnx offline, we can merge this and keep iterating if anything's missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Melange does a bunch of things with these quoted strings.To ease maintenance and prevent server rendering mismatches, the version of melange.ppx in server-reason-react could error out.Edit: see comment below.Partially fixes #139